Strange initialization
Strange initialization
Written by Antoni Boucher   
Article Index
Strange initialization
Solution

Solution

You add some code to the program in an effort find out what is happening but the result is only that you get very confused.

If you add this line in the main() function, you get a compiler error:

std::cout << data.at(0) << std::endl;

The compiler error message gives you a hint:

request for member ‘at’ in ‘data’, 
which is of non-class type
‘std::vector<std::basic_string<char> >
(std::istream_iterator<std::basic_string<char> >,
std::istream_iterator<std::basic_string<char> >
 (*)())’

The cause of the problem is that the compiler thinks it is facing a function prototype!

However, you want to create a vector, which is a variable definition. Clearly you are not interpreting the syntax in the same way.

How does the compiler see a function prototype?

Look again at this line:

vector<string> data(
istream_iterator<string>(cin),
istream_iterator<string>());

First of all, we have the return type (vector<string>).
After, we see the function name (data).

The rest is more difficult to see.

istream_iterator<string>(cin)

is seen as

istream_iterator<string> cin

by the compiler.  The compiler saw a parameter because the parentheses are superfluous.

Nevertheless, how does the compiler see the last argument?

It sees it as a pointer to a function which does not take any argument and returns istream_iterator<string>.

So the line can be read and interpreted as a function prototype!

To fix the problem, there are a few options:
You may add parentheses around argument like this:

vector<string> data((
istream_iterator<string>(cin)),
(istream_iterator<string>()));

You may use the copy initialization:

vector<string> data = vector<string>(
istream_iterator<string>(cin),
istream_iterator<string>());

And if your compiler supports C++0x, you may use initializers list:

vector<string> data{
istream_iterator<string>(cin),
istream_iterator<string>()};

Pattern

One way to avoid this problem happening is to always use copy initialization:

vector<string> data = vector<string>(
istream_iterator<string>(cin),
istream_iterator<string>());

Using this, you are sure it won't look like a function prototype.

Another rule to follow is to write code that uses the vector (like the at() method) after the declaration so you get a compiler error that will help you spot ambiguities.

 

Banner

More Puzzles

Sharpen Your Coding Skills
Self-Descriptive Arrays

Put on your thinking cap for another set of conundrums that will exercise your coding skills. This time Melvin Frammis introduces his junior partner Bugsy Cottman to some classic number puzzles that c [ ... ]


Sharpen Your Coding Skills
Towers Of Hanoi Mutants

Towers of Hanoi is a classic puzzle and is often used to illustrate the idea of recursion. Here you are challenged to find solutions to some variations, after first explaining the original version.


Sharpen Your Coding Skills
The Disaster Team Puzzle

Put on your thinking cap for another challenge that requires computational thinking. This time Melvin Frammis and his junior partner Bugsy Cottman need to respond to an emergency.


Other Articles

    <ASIN:0132673266>

    <ASIN:059600298X>

    <ASIN:0321334876>

    <ASIN:156592116X>



     
     

       
    Banner
    Banner
    RSS feed of all content
    I Programmer - full contents
    Copyright © 2017 i-programmer.info. All Rights Reserved.
    Joomla! is Free Software released under the GNU/GPL License.